[Bug 735665] gst-validate should concatenate its issue reporting in some cases.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=735665
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287559|none                        |needs-work
             status|                            |

--- Comment #22 from Thibault Saunier <tsaunier at gnome.org> 2014-10-02 07:32:23 UTC ---
Review of attachment 287559:
 --> (https://bugzilla.gnome.org/review?bug=735665&attachment=287559)

Minor comments, otherwize it looks good.

::: validate/gst/validate/gst-validate-pad-monitor.c
@@ +150,3 @@
+
+  /* For some reason this pad isn't monitored */
+  if (pad_monitor == NULL)

Does it actually happen? (I guess it can racily happen)

@@ -125,0 +125,101 @@
+static gboolean
+_find_master_report_on_pad (GstPad * pad, GstValidateReport * report)
+{
... 98 more ...

I would return right away if peerpad == NULL ... anyway.

@@ +254,3 @@
+    }
+  }
+  gst_object_unref (peerpad);

You can unref a NULL pointer here

@@ -125,0 +125,157 @@
+static gboolean
+_find_master_report_on_pad (GstPad * pad, GstValidateReport * report)
+{
... 154 more ...

I think you are done = TRUE here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.