[Bug 735665] gst-validate should concatenate its issue reporting in some cases.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Oct 2 20:07:24 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735665
  GStreamer | gst-devtools | git

--- Comment #23 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-10-03 03:07:19 UTC ---
Review of attachment 287559:
 --> (https://bugzilla.gnome.org/review?bug=735665&attachment=287559)

::: validate/gst/validate/gst-validate-pad-monitor.c
@@ +150,3 @@
+
+  /* For some reason this pad isn't monitored */
+  if (pad_monitor == NULL)

It can happen if you decide to only monitor certain pads, as I had done by
mistake while implementing the test :)

@@ -125,0 +125,101 @@
+static gboolean
+_find_master_report_on_pad (GstPad * pad, GstValidateReport * report)
+{
... 98 more ...

indeed

@@ +254,3 @@
+    }
+  }
+  gst_object_unref (peerpad);

True

@@ -125,0 +125,157 @@
+static gboolean
+_find_master_report_on_pad (GstPad * pad, GstValidateReport * report)
+{
... 154 more ...

True

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list