[Bug 739265] New: rtspsrc: teardown usually never happens

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739265
  GStreamer | gst-plugins-good | git

           Summary: rtspsrc: teardown usually never happens
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: aconchillo at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I was testing a problem with gst-rtsp-server when TEARDOWN is sent by the
client. Then, I saw that TEARDOWN was almost never being sent. I tracked it
down to rtspsrc.

Basically,

    case GST_STATE_CHANGE_PAUSED_TO_READY:
      gst_rtspsrc_loop_send_cmd (rtspsrc, CMD_CLOSE, CMD_PAUSE);
      ret = GST_STATE_CHANGE_SUCCESS;
      break;
    case GST_STATE_CHANGE_READY_TO_NULL:
      gst_rtspsrc_stop (rtspsrc);
      ret = GST_STATE_CHANGE_SUCCESS;
      break;

gst_rtspsrc_stop is being called to soon and CMD_CLOSE is never executed, thus
TEARDOWN is never sent.

I don't have a patch for this one. I think some sort of locking should happen
and make gst_rtspsrc_stop to wait for it. But this is completely different than
what gst_rtspsrc_stop is doing now.

To reproduce, just launch an gst-launch with rtspsrc and CTRL-C. You can check
with wireshark or simply looking to the logs.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.