[Bug 739265] rtspsrc: teardown usually never happens

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739265
  GStreamer | gst-plugins-good | git

--- Comment #1 from Aleix Conchillo Flaqué <aconchillo at gmail.com> 2014-10-28 23:21:15 UTC ---
Created an attachment (id=289556)
 View: https://bugzilla.gnome.org/attachment.cgi?id=289556
 Review: https://bugzilla.gnome.org/review?bug=739265&attachment=289556

always send TEARDOWN

This fixes it for me. These are the changes:

(1) In GST_STATE_CHANGE_PAUSED_TO_READY we allow CMD_CLOSE to cancel all
commands 
    not only CMD_PAUSE. It might be possible that CMD_PAUSE is already done and 
    CMD_LOOP is being executed, so we want to stop CMD_LOOP as well. So, now we 
    do:

    gst_rtspsrc_loop_send_cmd (rtspsrc, CMD_CLOSE, CMD_ALL);

(2) Because in (1) we might be interrupting CMD_LOOP and gst_rtspsrc_loop sends 
    a CMD_WAIT that would interrupt our CMD_CLOSE, we want to ignore that and 
    keep working on CMD_CLOSE.

(3) Finally, also in GST_STATE_CHANGE_PAUSED_TO_READY we wait on the stream 
    lock so we make sure teardown request was sent (or at least tried to).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.