[Bug 739281] video-blend: correct improper logic calculations

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Oct 29 21:50:13 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739281
  GStreamer | gst-plugins-base | unspecified

--- Comment #16 from Vineeth <vineeth.tm at samsung.com> 2014-10-30 04:50:08 UTC ---
Created an attachment (id=289625)
 View: https://bugzilla.gnome.org/attachment.cgi?id=289625
 Review: https://bugzilla.gnome.org/review?bug=739281&attachment=289625

test case to test the patch

I have created a simple test case to check the crash.

When x/y position is given more than dest frame width/height, then it crashes
with the present code, and after applying the attached patch it doesnt.

And the same should ideally happen for negative values.
But in video-blend src_width, src_height, dest_width, dest_height are being
declared as guint, hence even if we give negative values, it get wrongly
converted to positive, which i think is wrong.

Please verify the test case and the patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list