[Bug 739281] video-blend: correct improper logic calculations

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739281
  GStreamer | gst-plugins-base | unspecified

--- Comment #15 from Vineeth <vineeth.tm at samsung.com> 2014-10-29 06:53:31 UTC ---
another segfault found with gdkpixbufoverlay

gst-launch-1.0 -v videotestsrc ! gdkpixbufoverlay location=../icon.png
offset_x=10000 ! autovideosink
This will not crash with the patch attached. Since we are resetting the value
to 0, if x < 0 || x > dest_width

In case of negative values it behaves wrongly.
src_width is defined as guint.
so even if we pass negative values for x,
after src_width -= -x;
it gets converted to positive value, which in my opinion is wrong.

IMO src_width, src_height, dest_width, dest_height should be declared as gint,
and later we should adjust the same based on calculations.



I am trying to write a test case. But since i am new to writing test cases, it
might take some time..

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.