[Bug 742684] audiomixer: Un-even locking in GstAggregator causes the tests to fail

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742684
  GStreamer | gst-plugins-bad | git master

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295224|none                        |reviewed
             status|                            |

--- Comment #30 from Thibault Saunier <tsaunier at gnome.org> 2015-01-23 14:51:22 UTC ---
Review of attachment 295224:
 --> (https://bugzilla.gnome.org/review?bug=742684&attachment=295224)

::: gst-libs/gst/base/gstaggregator.c
@@ +195,2 @@
   aggpad->eos = FALSE;
   aggpad->priv->flushing = FALSE;

Flushing should not need locking and should be exclusively used atomically.

@@ +362,3 @@
     pad = l->data;

+    PAD_LOCK (pad);

Yeah, crazy that was not done!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.