[Bug 742684] audiomixer: Un-even locking in GstAggregator causes the tests to fail

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742684
  GStreamer | gst-plugins-bad | git master

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295225|none                        |reviewed
             status|                            |

--- Comment #31 from Thibault Saunier <tsaunier at gnome.org> 2015-01-23 14:55:25 UTC ---
Review of attachment 295225:
 --> (https://bugzilla.gnome.org/review?bug=742684&attachment=295225)

I see why you used the GST_OBJECT_LOCK to replace the EVENT_LOCK now, but I am
really afraid it is dangerous (mainly because that lock is associated with the
GCond), we should maybe expose a GST_AGGREGATOR_PAD_LOCK or provide getters for
those field and hide them in the Private structure?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.