[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #32 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-26 09:42:32 UTC ---
(In reply to comment #30)
> Review of attachment 295378 [details]:
> 
> Still not a fan of this API change, maybe instead returning a boolean, it
> should return the delay until the next RTCP packet, "0" meaning now. I assume
> that the first thing any implementation that receives FALSE will do is to check
> when the next scheduled packet is  and if it's soon enough, then it's as good
> as now. I still think that any implementation that makes a different between
> right now and "soon enough" is doing it wrong.

But it will already pass the "soon enough" as parameter (max-delay) to that
API. So the user of the API will tell it when "soon enough" ends, and if it's
not possible to send anything until then, FALSE is returned.

Why would any implementation that receives FALSE check when the next scheduled
packet would be, to do what? It already knows at that point that this specific
feedback it wanted to send is going to be late.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.