[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-26 16:00:16 UTC ---
(In reply to comment #31)
> (In reply to comment #28)
> > Review of attachment 295380 [details] [details]:
> > 
> > ::: gst/rtpmanager/rtpsession.c
> > @@ +3101,3 @@
> > +  if (gst_rtcp_buffer_get_first_packet (&rtcp, &packet)) {
> > +    /* FIXME: Do we also need to compare the ssrc in the packet with the
> > +     * source's ssrc? */
> > 
> > I think so, the packet we're trying to duplicate could also have come from
> > another peer in the group, and there could be multiple senders.
> 
> But if it is from another peer, we shouldn't send another request, right?
> Someone requested FIR already and that should give us a new keyframe too.

It's not clear to me what this SSRC is actually doing there. Also when
retaining RTCP packets, we store them next to the source that has the
corresponding media ssrc, so it might be correct here already.

What are these FIR packets? Are they this?
https://tools.ietf.org/html/rfc2032#section-5.2.1
If they are supposed to be this, I think we are creating and parsing them wrong
currently.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.