[Bug 746147] compositor: Don't convert or aggregate pads that are completely obscured by a higher zorder pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746147

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299662|none                        |reviewed
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 299662:
 --> (https://bugzilla.gnome.org/review?bug=746147&attachment=299662)

Test looks good in general, the GstVideoMeta::map() trick is neat.

::: tests/check/elements/compositor.c
@@ +1253,3 @@
+  buffer_mapped = FALSE;
+
+  alpha1 = g_rand_double_range (rand, 0.1, 0.9);

Using unseeded GRand seems like a bad idea. Do you really need random values
here ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.