[Bug 746147] compositor: Don't convert or aggregate pads that are completely obscured by a higher zorder pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746147

--- Comment #11 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #9)
> Review of attachment 299661 [details] [review]:
> 
> This looks good.
> 
> ::: gst/compositor/compositor.c
> @@ +339,3 @@
>      width = cpad->width;
>    else
> +    width = pad->info.width;
> 
> I'm not big fan of the accessor macros either, but I would recommend to make
> sure not using them here is fully concistent. The macro would have been
> GST_VIDEO_INFO_WIDTH()

I'm tempted to make the other uses not use the macro. :) Will submit an updated
patch.

(In reply to Nicolas Dufresne (stormer) from comment #10)
> Review of attachment 299662 [details] [review]:
> 
> Test looks good in general, the GstVideoMeta::map() trick is neat.
> 
> ::: tests/check/elements/compositor.c
> @@ +1253,3 @@
> +  buffer_mapped = FALSE;
> +
> +  alpha1 = g_rand_double_range (rand, 0.1, 0.9);
> 
> Using unseeded GRand seems like a bad idea. Do you really need random values
> here ?

>From the GLib documentation:

> g_rand_new()
> 
>Creates a new random number generator initialized with a seed taken either from /dev/urandom (if existing) or from the current time (as a fallback).

So, the seed is probably better than anything we could give it!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.