[Bug 746387] srtp: Add support for buffer list in srtpenc and srtpdec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746387

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299829|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299829:
 --> (https://bugzilla.gnome.org/review?bug=746387&attachment=299829)

::: ext/srtp/gstsrtpenc.c
@@ +1172,3 @@
+  if (!gst_srtp_enc_check_buffer (data->filter, *buffer, data->is_rtcp)) {
+    GST_WARNING_OBJECT (data->filter, "Invalid buffer, dropping");
+    buffer = NULL;

Either "gst_buffer_replace (buffer, NULL);" or "*gst_buffer_unref (*buffer);
buffer = NULL;"

@@ +1214,1 @@
+  gst_buffer_list_foreach (buf_list, validate_buffer_it, &validate_data);

Maybe check here if any buffer is left at all

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.