[Bug 746387] srtp: Add support for buffer list in srtpenc and srtpdec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746387

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299828|none                        |needs-work
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 299828:
 --> (https://bugzilla.gnome.org/review?bug=746387&attachment=299828)

::: ext/srtp/gstsrtpdec.c
@@ +1202,3 @@
+          validate_buffer (data->filter, *buffer, data->ssrc, data->is_rtcp)))
{
+    GST_WARNING_OBJECT (data->filter, "Invalid buffer, dropping");
+    buffer = NULL;

Same here

@@ +1216,3 @@
+          data->is_rtcp, data->ssrc)) {
+    GST_WARNING_OBJECT (data->filter, "Error decoding buffer, dropping");
+    buffer = NULL;

Same here

@@ +1245,3 @@
+
+  /* Check if this stream exists, if not create a new stream */
+  gst_buffer_list_foreach (buf_list, validate_buffer_it, &validate_data);

Maybe check if any is left at all

@@ +1255,3 @@
+  decode_data.is_rtcp = is_rtcp;
+
+  gst_buffer_list_foreach (buf_list, decode_buffer_it, &decode_data);

Maybe check if any is left at all

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.