[Bug 749109] codec-utils: add a gst_codec_utils_aac_get_sample_rate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749109

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303078|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 303078
  --> https://bugzilla.gnome.org/attachment.cgi?id=303078
codec-utils: add a gst_codec_utils_aac_get_sample_rate

I'm not sure yet if we really need this new function, but some review comments
nevertheless:


>+ * Returns the sample rate of the given AAC stream.
>+ *
>+ * Returns: The sample rate if rate_index is valid, 0 otherwise.
>+ */

Copy'n'paste from the index-based function. Should also have a Since: 1.6
marker at the end.


>+guint
>+gst_codec_utils_aac_get_sample_rate (const guint8 * audio_config)

Should take a size/length argument like the other functions (and check it).

>+  rate = gst_codec_utils_aac_get_sample_rate_from_index (rate_index);
>+  if (rate > 0)
>+    return rate;
>+  else
>+    return 0;
>+}

Might just as well just write

  return gst_codec_utils_aac_get_sample_rate_from_index (..)

then :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.