[Bug 749109] codec-utils: add a gst_codec_utils_aac_get_sample_rate

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749109

--- Comment #3 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 303078 [details] [review]
> codec-utils: add a gst_codec_utils_aac_get_sample_rate
> 
> I'm not sure yet if we really need this new function, but some review
> comments nevertheless:
> 
> 
> >+ * Returns the sample rate of the given AAC stream.
> >+ *
> >+ * Returns: The sample rate if rate_index is valid, 0 otherwise.
> >+ */
> 
> Copy'n'paste from the index-based function. Should also have a Since: 1.6
> marker at the end.
> 
> 
> >+guint
> >+gst_codec_utils_aac_get_sample_rate (const guint8 * audio_config)
> 
> Should take a size/length argument like the other functions (and check it).
> 
> >+  rate = gst_codec_utils_aac_get_sample_rate_from_index (rate_index);
> >+  if (rate > 0)
> >+    return rate;
> >+  else
> >+    return 0;
> >+}
> 
> Might just as well just write
> 
>   return gst_codec_utils_aac_get_sample_rate_from_index (..)
> 
> then :)

It's kind of you to help me. It's clear:)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.