[gst-devel] Re: [Ffmpeg-devel] ffmpeg patch for Solaris

[Michael Niedermayer]

Hi

On Friday 23 May 2003 19:12, Brian Cameron wrote:
> Gstreamer
> I'm attaching this patch which makes ffmpeg compile on Solaris with
> the Forte compiler.  It would be nice if these changes could go back
> to the community.  I think most of the changes are compiler agnostic.
>
> Sun would like to consider releasing ffmpeg in future releases of
> Solaris.  However, Sun's Gnome must compile with the Forte compiler.
> So I really hope these changes can go in.
[...]

>+#ifdef DEBUG
>     dprintf("frame %d:\n", s->frame_count);
>+#endif
why ?

>+#ifdef __SUNPRO_C
>+typedef struct {
>+#else
> typedef struct __attribute__((packed)) {
>+#endif
i dont think this is equivalent

>-    .extensions = "dv",
>+    NULL,
>+    "dv",
i dont like these changes, it makes the code much harder to read and error 
prone, so i leave the decission to apply or not to fabrice

anyway this patch isnt against cvs, so i cant apply it, even if i wanted to

[...]

-- 
Michael
level[i]= get_vlc(); i+=get_vlc();		(violates patent EP0266049)
median(mv[y-1][x], mv[y][x-1], mv[y+1][x+1]);	(violates patent #5,905,535)
buf[i]= qp - buf[i-1];				(violates patent #?)
for more examples, see http://mplayerhq.hu/~michael/patent.html
stop it, see http://petition.eurolinux.org & http://petition.ffii.org/eubsa/en