[gst-devel] Re: [gst-cvs] company gstreamer: gstreamer/ gstreamer/gst/

[Benjamin Otte]

On Mon, 26 Jan 2004, Thomas Vander Stichele wrote:

> > It only got added because of a bug somewhere else.
>
> Yep, by me, working on the system.
>
Nope, it was added by Julien to fix a compile issue he had, which was a
bug in a plugin as was quickly found out.

> > You're now free to remove it again since you obviously don't trust me.
>
> Sigh, trust has nothing to do with it, I would have mailed the exact
> same thing regardless of who would have done the commit.  In fact, I
> even agree with the patch, but that's not the point.
>
So you broke CVS on purpose just to prove a point?

> The point is - I explicitly sollicited comments on these issues, and am
> waiting on those comments to finish stuff.  It's only natural that you
> would just answer the question if you care, instead of directly
> committing a patch.  It's standard practice.
>
That code in there was non functional in that it didn't even have a
default error message associated with it and there were no
LIBRARY_DECODE_ERROR and friends.
So I removed that line, because apart from that line nothing looked as if
it should be there.
And I'd like to keep the headers as clean as possible.


As for your problem with LIBRARY error messages:
I didn't add anything to that because I don't have an opinion on it.

Benjamin