[PATCH] Add strlist support to hal-set-property for LUKS

[David Zeuthen]

On Tue, 2005-07-26 at 20:01 -0500, W. Michael Petullo wrote:
> Attached you should find a new revision of the patch.  I reverted to
> the old configure.in technique.

Thanks. I've committed the patch with a few changes; see below.

The first change was actually fixing hald so it didn't spin - after
looking at the debug output for hours I *think* a simple one-liner fixed
it. It's pretty complicated though. Works for me..

> The only known issue with the patch is that the volume MUST be unmounted
> or hal-luks-remove will not succede.  This is because the dm-crypt
> device may not be removed until the volume it hosts is unmounted.
> But hald won't unmount the volume until the dm-crypt device is removed.
> A chicken and egg issue.

Actually we can work around this. There's two cases

 - the cleartext device (/dev/dm-0) is removed before the backing
   device (/dev/sda1). Here we unmount /dev/dm-0 before tearing
   down the dm-crypt mapping in the latter; so this works already..

 - in the other case we just check whether the cleartext device 
   (/dev/dm-0) is mounted when processing the backing device
   (/dev/sda1) - we use volume.crypto_luks.clear.backing_volume
   to find it. I did this in hal-luks-remove.in using hal-find-by-
   property

Of course whether the kernel can cope with all this is another matter,
somewhat similar to how the kernel copes with removing storage devices
without unmounting file systems. In my few tests it works very well
though.

> On a related note, it seems that there is a regression related to the
> method interface.  Hald does not seem to be acting upon the dbus method
> request from gnome-volume-manager anymore.  Did the interface change?
> I have not yet had time to look at this closer.  In the mean time,
> I have been executing hal-luks-setup by hand.

Works for me; I think you manually need to chmod a+x the hal-luks-setup
since it's generated from a hal-luks-setup.in file. Does anyone know
enough autofoo to automatically do this? Please? =)

Cheers,
David


_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal