Add support for /sys/class/backlight

Holger Macht hmacht at suse.de
Fri Oct 6 08:07:49 PDT 2006


On Thu 05. Oct - 22:31:40, David Zeuthen wrote:
> On Thu, 2006-10-05 at 23:52 +0200, Holger Macht wrote:
> > Patch adding support for the /sys/class/backlight interface. If available,
> > a device /org/freedesktop/Hal/devices/computer_backlight is created. The
> > patch adds a class device and adjusts the scripts for the methods
> > GetBrightness and SetBrightness on the interface
> > org.freedesktop.Hal.Device.LaptopPanel. As soon as all kernel drivers are
> > converted to the new interface, we may drop the vendor specific code in
> > acpi.c.
> 
> Looks good to me. But probably only if a driver converts wholesale to
> the new sysfs interface, e.g. it either provides the old vendor-specific
> interface OR the new sysfs interface and not both at once. But I think
> this is the case for all drivers, yes? 

The kernel drivers will most likely keep the old /proc system for some
time because of the same reasons as we do, backward compatibility ;-)

> Cuz if this is not the case we probably need some code to skip
> vendor-specific checks if we find a sysfs backlight interface. And this
> is hard as the sysfs backlight interface probably can come and go.
> 
> Do you have commit access yet?

No, not yet, at least I didn't get any notifictation and a git clone with
my account name does not work.

Regards,
	Holger


More information about the hal mailing list