[PATCH] fix usage of unchecked returnval from
kay.sievers at vrfy.org
Mon Sep 11 14:57:52 PDT 2006
On Mon, 2006-09-11 at 17:47 -0400, David Zeuthen wrote:
> On Mon, 2006-09-11 at 23:13 +0200, Danny Kukawka wrote:
> > Hi,
> > this patch fixes the usage of unchecked returnvalue from
> > hal_util_strdup_valid_utf8(). The function returns NULL if there is no way to
> > return a valid or a fixed validate string. A uncheck usage can cause this
> > error:
> > GLib-CRITICAL **: g_strlcpy: assertion `src != NULL' failed
> > Please review.
> Looks good to me, thanks. Looks like udev ought to not provide data
> which is not UTF-8, it should probably be fixed in udev too. Or perhaps
> not, depends on udev and whether it just should return raw data. Kay?
Udev usually does not return any control characters, or non-utf-8, or
invalid utf-8 character sequences. If it does, let me know.
More information about the hal