[PATCH][RFC] cache generation + separate FDI parser process

[Sergey Lapin]

> It should probably be /var/cache/hald cf. the FHS 2.3
> 
>  http://www.pathname.com/fhs/pub/fhs-2.3.html#VARCACHEAPPLICATIONCACHEDATA
> 
> as it really is a cache.
Ok, will change that.

> 
>> Debug scripts are not changed, they need to be added running of that binary.
> 
> As discussed elsewhere hald should probably check cache coherency;
> requires traversing all directories we care about.
> 
...
>> Possible TODO:
>>
>> move hald-cache-test to noinst
> 
> Yes, sounds like a good idea.
> 
>> provide check for cache to be consistent with FDI files (newer).
> 
> Yes. And also, we should hook up inotify as noted in another mail.
> 
> Quick comments on the patch
> 
>> +++ b/hald/cache_test.c
>> @@ -0,0 +1,78 @@
>> +/***************************************************************************
>> + * CVSID: $Id$
>> + *
>> + * device_info.c : match/merge device properties.
> 
> Copy/paste? (this occurs several times)
Yeah, was a bit sleepy today and missed that.

> 
> 
>> +static void test_cache(u_int32_t offset, size_t size){
>> +    u_int32_t		m = offset;
>> +    struct rule 	*r;
> 
> Please follow the code formatting guidelines used in the rest of the
> source tree.

Will fix that tomorrow.

> 
>> +
>> +#define MAX_INDENT_DEPTH		64
> 
> Probably needs some prefix here.
Seems so.

> 
> This is just a quick look through. I think with these changes + the
> cache coherency checks + automatic invocation of this tool.. we're good
> to commit it and start testing it. Then we can add inotify + other
> checks on top. Sounds good?
Sounds excellent!

Ok, so I'll submit updated patch tomorow night! Thanks!