[PATCH][RFC] cache generation + separate FDI parser process

David Zeuthen david at fubar.dk
Wed Jan 10 21:52:34 PST 2007


On Wed, 2007-01-10 at 20:32 +0300, Sergey Lapin wrote:
> - Fixed code style issues and cut-paste comment errors
> - Created trivial cache coherency check (mtime)
> - moved test binary to noinst
> - made proper command line options for hald-cache
> - proper logger setup with hald-cache

I've committed the patch with the following changes

 - CACHE_FILE and HALD_CACHE_BIN shouldn't be set from configure.in

 - instead of installing the helper in /sbin and caling it hald-cache
   rather call it hald-generate-fdi-cache and install it in /usr/libexec
   since only hald will call it

 - make the runner capable of invoking programs when device==NULL

 - make hald invoke the fdi cache generator using the runner; otherwise
   ./run-hald.sh and friends will not work if your home directory is
   unreadable by the haldaemon user

 - create /var/cache/hald in install-data-local. Also fixup the missing
   use of $DESTDIR of /var/run/hald stuff

 - s/cache_coherency_check()/di_cache_coherency_check()/

 - wait for runner to be initialized before invoking
   di_cache_coherency_check()

 - fix di_cache_coherency_check() so it respects $HAL_FDI_SOURCE_* and
   also $HAL_FDI_CACHE_NAME

 - remote the cache-test program for now as we now require the runner

 - fix up ./run-hald.sh and friends to use a cache in .local-fdi thereby
   not polluting the global cache

The full diff of my changes (on top of your patch) is here

 http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=de7ada8fd2a5675554d6723b9145afa4e719e8a0;hp=285b20f453bd4ce5f963a9818711c7ffd38437d7

Hopefully I didn't break too much! I'm curious, don't you
use ./run-hald.sh to do development? It's very useful, by design it's
made such that you can run hald from your local source tree without
'make install'.

Thanks again for the patch!

Cheers,
David




More information about the hal mailing list