[Intel-gfx] Prepare for 2.3.2

Zhenyu Wang zhen78 at gmail.com
Sun Jun 15 19:39:19 CEST 2008


On 2008.06.15 10:57:09 +0200, Lukas Hejtmanek wrote:
> On Mon, Jun 16, 2008 at 12:47:20AM +0800, Zhenyu Wang wrote:
> > Current we still guard 0 backlight in panel setting, and I think we
> > might be better to ignore it for 'kernel' backlight method, aka acpi
> > method. Platform will normally define level 0 to be appropriate minimal
> > value, but not some insane close-to-black brightness. So in this case
> > we won't need to turn it into max by always.
> 
> However, if you guard 0 backlight level or not, it still resets the backlight
> value to 0 as I explained. The code turns DPMS off and then it calls randr
> init which reads and sets the current value (which is 0).

When I tested on T61 with thinkpad_acpi (brightness_enable=1), acpi
seems have 0~15 backlight levels defined, and Fn keys will call bios
to set brightness. If I turn it into lowest level 0, then X start will
bring max brightness to me. I think it's caused by current 0 level
check.



More information about the Intel-gfx mailing list