[Intel-gfx] [PATCH 1/3] drm/i915: implement new pm ops for i915

Eric Anholt eric at anholt.net
Wed Dec 16 18:42:33 CET 2009


On Wed, 16 Dec 2009 13:36:10 +0800, Zhenyu Wang <zhenyuw at linux.intel.com> wrote:
> On 2009.12.02 09:36:48 -0800, Jesse Barnes wrote:
> > 
> > > On 2009.11.25 13:09:37 +0800, Zhenyu Wang wrote:
> > > > One problem in i915 hibernate with current legacy pci pm ops is
> > > > that after we do freeze, we'll be forced to do resume once again,
> > > > which re-init some resources and do modesetting again, that is
> > > > unnecessary for hibernate. This patch trys to bypass that.
> > > > 
> > > > We can't resolve this within legacy pm framework, but can do it
> > > > easily with new pm ops. Suspend (S3) process has also been kept
> > > > without change.
> > > 
> > > Any comment or concern about this one?
> > > 
> > > This patch only changes for hibernate (S4), and removes screen
> > > flicking (extra modesetting) during hibernate before power off
> > > machine. If any other device failed in the hibernate process, the
> > > driver for it should be fixed and worst case is a VT switch to bring
> > > back X.
> > 
> > Yeah sorry meant to look at this but it got lost.  It looks ok, the
> > core DRM should probably be converted too.  I had some patches for that
> > awhile back but I think the interfaces have changed since then...
> > 
> 
> Looks it should be specified by driver in KMS case as always true now.
> Updated one below.

Applied.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091216/3644723c/attachment.pgp>


More information about the Intel-gfx mailing list