[Intel-gfx] [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump support

Fengguang Wu fengguang.wu at intel.com
Wed Aug 15 10:00:59 CEST 2012


Xingchao,

Have you tested the patch in haswell as well as in older hardwares?
In general it would be better if you have run this tool for some time
on several hardwares -- that's the best way to smooth out possible bugs.

> +/*Haswell registers*/

Please fix the style to (ditto for lots of other comments)

> +/* Haswell registers */

Thanks,
Fengguang



More information about the Intel-gfx mailing list