[Intel-gfx] [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump support

[Wang, Xingchao]

Hi Fengguang,

> -----Original Message-----
> From: Wu, Fengguang
> Sent: Wednesday, August 15, 2012 4:01 PM
> To: Wang, Xingchao
> Cc: intel-gfx at lists.freedesktop.org; daniel at ffwll.ch; Fu, Michael;
> zhenyuw at linux.intel.com
> Subject: Re: [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump
> support
> 
> Xingchao,
> 
> Have you tested the patch in haswell as well as in older hardwares?

I tested this patch on Haswell platform platform several times. It helped me much during debug.
And this patch has no impact for older hardwares(such as ivybridge), as it only works for Haswell.

> In general it would be better if you have run this tool for some time on several
> hardwares -- that's the best way to smooth out possible bugs.
> 
> > +/*Haswell registers*/

> 
> Please fix the style to (ditto for lots of other comments)
> 
> > +/* Haswell registers */

Thanks, will clean up that.

--xingchao