[Intel-gfx] [PATCH 0/2] Dynamic power wells support

Paulo Zanoni przanoni at gmail.com
Tue Dec 4 17:48:54 CET 2012


From: Paulo Zanoni <paulo.r.zanoni at intel.com>

Hi

Daniel recently sent a patch to support disabling the power well, but when
reviewing it I discovered that our code to enable/disable the power well - not
part of Daniel's patch, only used by it - is broken. So I created a patch to fix
this problem and then ported Daniel's patch to be on top of the fix.

With this, we are finally capable of correctly disabling/enabling the power
well, but we are also uncovering a huge problem: we now get tons of "unclaimed
register" errors, because we read/write the registers inside the "power down
well" even when they're not being used.

I think we can try to apply patch 01 now, but before applying patch 02 we should
probably try to get rid of all those "unclaimed register" messages that it
brings. This will certainly not be a small task. I can volunteer myself to do
this, but considering my TODO list I will certainly not be able to address this
problem before January. The first step is certainly to avoid calling
ivb_disable_plane: this alone will already remove most of the error messages.

Comments? Volunteers?

Thanks,
Paulo

Daniel Vetter (1):
  drm/i915: dynamic Haswell display power well support

Paulo Zanoni (1):
  drm/i915: fix intel_init_power_wells

 drivers/gpu/drm/i915/i915_reg.h      |  8 ++---
 drivers/gpu/drm/i915/intel_ddi.c     |  8 ++++-
 drivers/gpu/drm/i915/intel_display.c | 36 ++++++++++++++++---
 drivers/gpu/drm/i915/intel_drv.h     |  3 +-
 drivers/gpu/drm/i915/intel_pm.c      | 70 +++++++++++++++++++++++++++---------
 5 files changed, 98 insertions(+), 27 deletions(-)

-- 
1.7.11.7




More information about the Intel-gfx mailing list