[Intel-gfx] [PATCH] drm/i915: Clear the existing watermarks for g4x when modifying the cursor sr

Daniel Vetter daniel at ffwll.ch
Tue Dec 4 22:44:25 CET 2012


On Tue, Dec 04, 2012 at 05:48:53PM -0200, Paulo Zanoni wrote:
> Hi
> 
> 2012/12/4 Chris Wilson <chris at chris-wilson.co.uk>:
> > In a couple of places we attempt to adjust the existing watermark
> > registers to update them for the new cursor watermarks. This goes
> > horribly wrong as instead of clearing the cursor bits prior to or'ing in
> > the new values, we clear the rest of the register with the result that
> > the watermark registers contain bogus values.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=47034
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> Nice catch...

Indeed. Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list