[Intel-gfx] [PATCH 2/2] drm/i915: debugfs: show semaphore registers also on gen7

Eugeni Dodonov eugeni at dodonov.net
Tue Jan 24 15:45:31 CET 2012


On Tue, Jan 24, 2012 at 06:44, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> Corresponding changes to improve our error_state are pending
> some other patches to clean up things first.
>
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>

I've send the patches to provide .has_semaphores and .has_rc6 features not
that long ago, perhaps it is time to reconsider them to simplify such
checks?

The logic behind their rejection at that time was that it not the right
things to rely on such flags for feature functionality status (in that
time, I intended to use them to make rc6/semaphores available on IVB by
default - in yet another attempt to have somewhat working default for each
gpu generation). But perhaps we could use those just to announce which GPUs
has the features instead of relying on IS_GEN checks? This would cover the
RC6, Turbo and Semaphores items for now for example.

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120124/e75f77c5/attachment.html>


More information about the Intel-gfx mailing list