[Intel-gfx] [PATCH 17/24] drm/i915: disable pipe DDI function when disabling pipe

[Jesse Barnes]

On Thu, 26 Apr 2012 15:21:12 -0300
Eugeni Dodonov <eugeni.dodonov at intel.com> wrote:

> Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 5be2ff1..b7e50af 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -1627,6 +1627,16 @@ static void intel_disable_pipe(struct drm_i915_private *dev_priv,
>  
>  	I915_WRITE(reg, val & ~PIPECONF_ENABLE);
>  	intel_wait_for_pipe_off(dev_priv->dev, pipe);
> +
> +	/* On HSW, disable pipe DDI function the pipe */
> +	if (IS_HASWELL(dev_priv->dev)) {
> +		val = I915_READ(DDI_FUNC_CTL(pipe));
> +		val &= ~PIPE_DDI_PORT_MASK;
> +		val &= ~PIPE_DDI_FUNC_ENABLE;
> +		I915_WRITE(DDI_FUNC_CTL(pipe),
> +				val);
> +	}
> +
>  }
>  
>  /*

Looks like we could just write 0 here?

-- 
Jesse Barnes, Intel Open Source Technology Center