[Intel-gfx] [PATCH] drm/i915: fix gen4 gpu reset

Eugeni Dodonov eugeni.dodonov at linux.intel.com
Fri May 4 19:06:29 CEST 2012


On 05/02/2012 04:33 PM, Daniel Vetter wrote:
> While trying to fix up gen4 gpu reset in
>
> commit f49f0586191fe16140410db0a46d43bdc690d6af
> Author: Kenneth Graunke<kenneth at whitecape.org>
> Date:   Sat Sep 11 01:19:14 2010 -0700
>
>      drm/i915: Actually set the reset bit in i965_reset
>
> a little confusion about when wait_for times out has been introduced -
> wait for loops _until_ the condition is true.
>
> This fixes gpu reset on my gm45, testing with my hangman code shows
> that it's now fairly reliable - it only died after well over 100 reset
> cycles.
>
> Cc: Kenneth Graunke<kenneth at whitecape.org>
> Cc: Eric Anholt<eric at anholt.net>
> Signed-Off-by: Daniel Vetter<daniel.vetter at ffwll.ch>

I haven't tested it on a real machine to verify if it actually does the 
reset, but this change does explains why it could not work before :).

Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>



More information about the Intel-gfx mailing list