[Intel-gfx] [PATCH 2/2] drm/i915/dp: Remove eDP special cases from bandwidth checks

Daniel Vetter daniel at ffwll.ch
Thu May 10 21:14:24 CEST 2012


On Thu, May 10, 2012 at 07:40:23PM +0100, Chris Wilson wrote:
> On Mon, 17 Oct 2011 13:29:18 -0400, Adam Jackson <ajax at redhat.com> wrote:
> > On Fri, 2011-10-14 at 23:13 -0700, Keith Packard wrote:
> > > On Fri, 14 Oct 2011 12:43:50 -0400, Adam Jackson <ajax at redhat.com> wrote:
> > > 
> > > > These were just working around the math being wrong.
> > > 
> > > One wonders whether this might break some machines which are currently
> > > working. Should we emit an error or something if an eDP panel asks for
> > > the impossible?
> > 
> > Probably, but I think in cases where that happens we should be
> > considering the driver to be broken before the panel.  No one's going to
> > manufacture hardware that can't run Windows.
> 
> Sigh, This patch did introduce a number of regressions, notably
> https://bugs.freedesktop.org/show_bug.cgi?id=45801

To clarify, the first patch (fix dp math) broke stuff, not the second one
(rip out edp special case) for this reporter.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list