[Intel-gfx] [PATCH] Fix GM965 TV out regression

Chris Wilson chris at chris-wilson.co.uk
Sat May 19 21:06:41 CEST 2012


On Sat, 19 May 2012 20:38:20 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sat, May 19, 2012 at 04:52:10PM +1000, Robert Lowery wrote:
> > Could someone please apply the following which I have confirmed re-fixes
> > the issue for my TV output via component video connection.

> Rodrigo, can you please check this patch with the docs and maybe quickly
> run it?

The patch looks reasonable (just lacking a POSTING_READ prior to the
wait as that is not guaranteed by the wait). My guess would be that we
need a vblank to be sure that the writes latched and we indeed switched
off the detection mode prior to turning the pipe off. Not sure how that
results in ghost TV detection, and so it would be good to capture any
final explanation as a code comment to make sure that the wait isn't
deleted again in future.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list