[Intel-gfx] [PATCH 01/11] drm/i915: add set_infoframes to struct intel_hdmi

Chris Wilson chris at chris-wilson.co.uk
Fri May 25 01:02:53 CEST 2012


On Thu, 24 May 2012 17:49:43 -0300, Paulo Zanoni <przanoni at gmail.com> wrote:
> +void g4x_set_infoframes(struct drm_encoder *encoder,
> +			struct drm_display_mode *adjusted_mode)

This and all that follow should be static. Adding a non-intel function
to our module's namespace is indicative of a gross hack, or as in this
case, a mistake.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list