[Intel-gfx] [PATCH 2/3] drm/i915: initialize the parity work only once

Ben Widawsky ben at bwidawsk.net
Thu May 31 18:30:34 CEST 2012


On Thu, 31 May 2012 14:57:42 +0200
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> This fixes an (albeit really hard to hit) race resulting in an oops:
> - The parity work get scheduled.
> - We re-init the irq state and call INIT_WORK again.
> - The workqueue code tries to run the work item and stumbles over a
>   work item that should be on it's runlist.
> 
> Also initiliaze the work item unconditionally like all the others,
> it's simpler.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Reviewed-by: Ben Widawsky <ben at bwidawsk.net>

I am not sure how this got dropped. It's in one of my branches
somewhere.



More information about the Intel-gfx mailing list