[Intel-gfx] [PATCH 15/33] drm/i915: DSPARB register needs an offset on VLV

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Jan 25 13:05:04 CET 2013


On Thu, Jan 24, 2013 at 11:01:42PM +0100, Daniel Vetter wrote:
> On Thu, Jan 24, 2013 at 03:29:40PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> With Paulo's patch to no longer safe/resume DSPARB on gen4+ gone, there's
> no user of this left for vlv. And I wouldn't be surprised at all if the
> register has a completely different function now, so maybe if we ever need
> it we need a VLV_DSPARB or something like that.

It has the same function, but the bits naturally get shuffled around a
lot. We can revisit it when/if it's really needed.

-- 
Ville Syrjälä
Intel OTC



More information about the Intel-gfx mailing list