[Intel-gfx] [PATCH] drm/i915: add intel_display_power_enabled_sw for use in atomic ctx

Imre Deak imre.deak at intel.com
Wed Nov 27 19:42:36 CET 2013


On Wed, 2013-11-27 at 19:38 +0100, Daniel Vetter wrote:
> On Wed, Nov 27, 2013 at 7:30 PM, Ville Syrjälä
> <ville.syrjala at linux.intel.com> wrote:
> > I'm not sure the barriers really provide extra value. Some other
> > thread could still come along just after this and disable the power
> > wells.
> 
> Yeah, the barrriers don't really add anything - the access from the
> capture code is racy, but we don't really care about that. I'd still
> like to see us dump this information into the error state though since
> now the sw tracking could get out of sync with the hw and leave us
> puzzled when trying to analyze such a dump.

Right, so calling any form of intel_display_power_enabled() is
pointless. So that should be also removed and the value of
intel_display_power_enabled_sw() saved.

--Imre

> -Daniel





More information about the Intel-gfx mailing list