[Intel-gfx] [PATCH] drm/i915: Update PM interrupts before updating the freq

Chris Wilson chris at chris-wilson.co.uk
Sat Jul 11 09:46:37 PDT 2015


On Fri, Jul 10, 2015 at 06:31:40PM +0530, Praveen Paneri wrote:
> From: Deepak S <deepak.s at intel.com>
> 
> Currently we update the freq before masking the interrupts, which can
> allow new interrupts to occur before the frequency has changed. These
> extra interrupts might waste some cpu cycles. This patch corrects
> this by masking interrupts prior to updating the frequency.

Well it won't waste CPU cycles as the interrupt is also masked by the
threshold limits, but there should be no harm at all in reordering the
patch so, and it does make a certain amount of sense.

> Signed-off-by: Deepak S <deepak.s at intel.com>
> Signed-off-by: Praveen Paneri <praveen.paneri at intel.com>

Quibbling over the language in the changelog aside,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list