[Intel-gfx] [PATCH] drm/i915: Update PM interrupts before updating the freq

Daniel Vetter daniel at ffwll.ch
Mon Jul 13 02:28:23 PDT 2015


On Sat, Jul 11, 2015 at 05:46:37PM +0100, Chris Wilson wrote:
> On Fri, Jul 10, 2015 at 06:31:40PM +0530, Praveen Paneri wrote:
> > From: Deepak S <deepak.s at intel.com>
> > 
> > Currently we update the freq before masking the interrupts, which can
> > allow new interrupts to occur before the frequency has changed. These
> > extra interrupts might waste some cpu cycles. This patch corrects
> > this by masking interrupts prior to updating the frequency.
> 
> Well it won't waste CPU cycles as the interrupt is also masked by the
> threshold limits, but there should be no harm at all in reordering the
> patch so, and it does make a certain amount of sense.

Added and ...
> 
> > Signed-off-by: Deepak S <deepak.s at intel.com>
> > Signed-off-by: Praveen Paneri <praveen.paneri at intel.com>
> 
> Quibbling over the language in the changelog aside,
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list