[Intel-gfx] [PATCH] drm/i915: Remove redundant check in i915_gem_obj_to_vma

[Tvrtko Ursulin]

On 12/11/15 12:29, Chris Wilson wrote:
> On Thu, Nov 12, 2015 at 11:59:55AM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> No need to verify VMA belongs to GGTT since:
>>
>> 1. The function must return a normal VMA belonging to passed in VM.
>> 2. There can only be one normal VMA for any VM.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Reviewed-by Chris Wilson <chris at chris-wilson.co.uk>

Thanks!

>> Maybe now even a candidate for making a static inline?
>
> No. After tracking vma, i915_gem_obj_to_vma() is moved off the hotpaths
> and mostly used for the first lookup by an execbuffer, context creation,
> modesetting and debug code.

Well I thought I wouldn't harm in the interim, since there are only 
three callers in total, two of which are performance sensitive, and if 
inlined code would now probably quite compact.

How is the rewrite coming along then?

Regards,

Tvrtko