[Intel-gfx] [PATCH v2 3/3] drm/i915/icl+: Always use TPS2 or TPS3 when exiting PSR

kbuild test robot lkp at intel.com
Wed Mar 6 07:41:33 UTC 2019


Hi José,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.0 next-20190305]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jos-Roberto-de-Souza/drm-i915-vbt-Parse-and-use-the-new-field-with-PSR2-TP2-3-wakeup-time/20190306-140524
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x019-201909 (attached as .config)
compiler: gcc-8 (Debian 8.3.0-2) 8.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10,
                    from include/linux/list.h:9,
                    from include/linux/async.h:16,
                    from drivers/gpu/drm/i915/intel_drv.h:28,
                    from drivers/gpu/drm/i915/intel_psr.c:55:
   drivers/gpu/drm/i915/intel_psr.c: In function 'psr1_tps_regs_val_get':
>> include/linux/compiler.h:58:2: error: expected ';' before 'if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
     ^~
   include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
    #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
                          ^~~~~~~~~~
   drivers/gpu/drm/i915/intel_psr.c:446:2: note: in expansion of macro 'if'
     if (dev_priv->vbt.psr.tp1_wakeup_time_us == 0)
     ^~
--
   In file included from include/linux/kernel.h:10,
                    from include/linux/list.h:9,
                    from include/linux/async.h:16,
                    from drivers/gpu//drm/i915/intel_drv.h:28,
                    from drivers/gpu//drm/i915/intel_psr.c:55:
   drivers/gpu//drm/i915/intel_psr.c: In function 'psr1_tps_regs_val_get':
>> include/linux/compiler.h:58:2: error: expected ';' before 'if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
     ^~
   include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if'
    #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
                          ^~~~~~~~~~
   drivers/gpu//drm/i915/intel_psr.c:446:2: note: in expansion of macro 'if'
     if (dev_priv->vbt.psr.tp1_wakeup_time_us == 0)
     ^~

vim +58 include/linux/compiler.h

2bcd521a Steven Rostedt 2008-11-21  50  
2bcd521a Steven Rostedt 2008-11-21  51  #ifdef CONFIG_PROFILE_ALL_BRANCHES
2bcd521a Steven Rostedt 2008-11-21  52  /*
2bcd521a Steven Rostedt 2008-11-21  53   * "Define 'is'", Bill Clinton
2bcd521a Steven Rostedt 2008-11-21  54   * "Define 'if'", Steven Rostedt
2bcd521a Steven Rostedt 2008-11-21  55   */
ab3c9c68 Linus Torvalds 2009-04-07  56  #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
ab3c9c68 Linus Torvalds 2009-04-07  57  #define __trace_if(cond) \
b33c8ff4 Arnd Bergmann  2016-02-12 @58  	if (__builtin_constant_p(!!(cond)) ? !!(cond) :			\
2bcd521a Steven Rostedt 2008-11-21  59  	({								\
2bcd521a Steven Rostedt 2008-11-21  60  		int ______r;						\
2bcd521a Steven Rostedt 2008-11-21  61  		static struct ftrace_branch_data			\
e04462fb Miguel Ojeda   2018-09-03  62  			__aligned(4)					\
e04462fb Miguel Ojeda   2018-09-03  63  			__section("_ftrace_branch")			\
2bcd521a Steven Rostedt 2008-11-21  64  			______f = {					\
2bcd521a Steven Rostedt 2008-11-21  65  				.func = __func__,			\
2bcd521a Steven Rostedt 2008-11-21  66  				.file = __FILE__,			\
2bcd521a Steven Rostedt 2008-11-21  67  				.line = __LINE__,			\
2bcd521a Steven Rostedt 2008-11-21  68  			};						\
2bcd521a Steven Rostedt 2008-11-21  69  		______r = !!(cond);					\
97e7e4f3 Witold Baryluk 2009-03-17  70  		______f.miss_hit[______r]++;					\
2bcd521a Steven Rostedt 2008-11-21  71  		______r;						\
2bcd521a Steven Rostedt 2008-11-21  72  	}))
2bcd521a Steven Rostedt 2008-11-21  73  #endif /* CONFIG_PROFILE_ALL_BRANCHES */
2bcd521a Steven Rostedt 2008-11-21  74  

:::::: The code at line 58 was first introduced by commit
:::::: b33c8ff4431a343561e2319f17c14286f2aa52e2 tracing: Fix freak link error caused by branch tracer

:::::: TO: Arnd Bergmann <arnd at arndb.de>
:::::: CC: Steven Rostedt <rostedt at goodmis.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 25909 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190306/98c6eafd/attachment-0001.gz>


More information about the Intel-gfx mailing list