[Libreoffice-bugs] [Bug 112369] New: Improve the workflow of adding items to menus

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=112369

            Bug ID: 112369
           Summary: Improve the workflow of adding items to menus
           Product: LibreOffice
           Version: 6.0.0.0.alpha0+ Master
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: UI
          Assignee: libreoffice-bugs at lists.freedesktop.org
          Reporter: muhammet.kara at pardus.org.tr

This is a spin off from
https://bugs.documentfoundation.org/show_bug.cgi?id=112133

 Muhammet Kara 2017-09-13 10:09:37 UTC
(In reply to Heiko Tietze from comment #12)
> When adding a command to a menu or context menu that already contains this
> items a confirmation box is shown telling the user that this operation is
> not possible. Not the best approach, and you better disable the add button.

This requires some more dev effort than the polishing task itself requires.
Let's separate it.

Instead of checking for duplicates after pressing the add button, we may check
for duplicates in SvxMenuConfigPage::UpdateButtonStates(), and make sure it is
called from both SelectMenu and SelectFunctionHdl.

Note that SelectMenu is in SvxMenuConfigConfigPage, while SelectFunctionHdl is
in SvxConfigPage. So it might be a good idea to move one of them to the parent
or to the child class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170913/142971eb/attachment-0001.html>