[Libreoffice-bugs] [Bug 112486] [META] Bugs caused/worsened by using DirectWrite more

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=112486

Aron Budea <baron at caesar.elte.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |khaledhosny at eglug.org
             Blocks|                            |109234
            Summary|[META] Bugs caused/worsened |[META] Bugs caused/worsened
                   |by forcing GDI when needed  |by using DirectWrite more
              Alias|Regressions-forcing-GDI     |Regressions-from-more-DWrit
                   |                            |e

--- Comment #5 from Aron Budea <baron at caesar.elte.hu> ---
Let's point to Khaled's analysis (thanks for that):
"Hmm, I don’t think you need to revert the whole change. Looking into
this again, I think there are two unrelated changes in this commit;
forcing GDI for non-horizontal text which fixed the two bugs, and
optionally not using GDI when not using OpenGL (previously we always
used GDI when OpenGL was used). I think it was wishful thinking of my
part to think the non-GDI code path is usable.

In short, I guess you just need to change the !bUseOpenGL branch back to:

        DrawTextLayout(rLayout, hDC, false);

This should fix the newly introduced issues. I can’t test this myself
right now, though, and might not be able to do so for few more weeks.
It might also cause a regression for some Graphite fonts, but I
don’t remember the details, but it shouldn’t be hard to have a
CommonSalLayout::isGraphite() or so to signal such fonts and not use
GDI for them."
http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html#a4223433


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109234
[Bug 109234] [META] DirectWrite rendering bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20170925/7e5a0c9e/attachment-0001.html>