[Libreoffice-bugs] [Bug 138252] LibreOffice doesn't preserve facls (create new files on save and ignores old facls)

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=138252

Stephan Bergmann <sbergman at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbergman at redhat.com

--- Comment #1 from Stephan Bergmann <sbergman at redhat.com> ---
capturing the recent discussion on FreeNode #libreoffice-dev:

> Nov 17 14:52:36 <sberg_> vmiklos, I tend to remember you once added code (in sfx2 or similar) to preserve certain attributes of the original file when a new version of a document is saved, similar to how tdf#138252 now asks for extended ACLs to be preserved on Linux?
> Nov 17 14:52:38 <IZBot> LibreOffice-Calc normal/medium UNCONFIRMED LibreOffice doesn't preserve facls (create new files on save and ignores old facls) https://bugs.documentfoundation.org/show_bug.cgi?id=138252
> Nov 17 14:54:39 <vmiklos> sberg_: IsFileMovable() in sfx2/source/doc/docfile.cxx this to decide if we can move the tmp file to the final destination or we have to copy the bytes over
> Nov 17 14:55:43 <vmiklos> osl::File::replace() is what it uses, which is just a plain rename() in the linux case, there is some better "replace and inherit the destination properties" api on windows.
> Nov 17 14:57:06 <sberg_> vmiklos, I think I'd thought of something else (a place that copies the Unix user/group/other permission bits, say), but I may well misremember anyway
> Nov 17 14:58:12 <vmiklos> sberg_: that GetDefaultFileAttributes() + osl::File::setAttributes() at the same place where IsFileMovable() gets called?
> Nov 17 14:58:13 <sberg_> vmiklos, ah, that "// Adjust attributes" stuff later in that file...
> Nov 17 14:58:23 <sberg_> yeah :)
> Nov 17 14:59:12 <vmiklos> i don't have a strong opinion on that file moving, it's possible we should just give up on this on linux, and make it windows-only, where we have a good api to replace content..
> Nov 17 15:00:13 <noelgrandin> I thought I saw something on the kernel mailing list about one of the filesystems implementing this kind of thing
> Nov 17 15:01:19 <sberg_> vmiklos, benefit is probably that it makes it harder to get a file truncated in the middle if things go wrong midway
> Nov 17 15:02:38 <noelgrandin> those of us with flakey power thank the people who implement such things
> Nov 17 15:03:27 <vmiklos> sberg_: yes, i though this is really standard way of doing things, but then people complained about all sort of corner-cases :) so now i'm less sure this was a good idea after all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20201117/7139ed96/attachment-0001.htm>