ESC meeting minutes: 2024-02-29
Miklos Vajna
vmiklos at collabora.com
Thu Feb 29 15:54:09 UTC 2024
* Present:
+ Cloph, Olivier, Caolan, Heiko, Ilmari, Michael W, Stephan, Xisco, Regina, Michael S, Sanchu, Eike, Thorsten, Miklos
* Completed Action Items:
+ add “Deprecating Windows 7 and 8/8.1” to the 24.8 release notes (Ilmari)
* Pending Action Items:
* Release Engineering update (Cloph)
+ 7.6: 7.6.6 RC1 in 1 week
+ 24.2.2 RC1 1 week
+ app store versions:
+ 7.6.5 published as an update
+ update checker is now also enabled for 7.5 -> 7.6
+ Windows MAR updater status? (Thorsten)
+ not yet, but should happen next week (Cloph)
* Documentation (Olivier)
+ Helpcontents2
+ Housekeeping and update + bug squash (D. Maddern, stragu, ohallot)
+ New pages for new MS functions (ohallot)
+ Scriptforge maintenance (A. Romedenne)
Q: Does F1 works with toolbars?
+ F1 on Toolbars send a default bookmark (ohallot)
+ did this work in the past?
+ probably not: F1 works on the widget that has the focus (Miklos)
+ hovering over a mouse button doesn't change the focus
+ one can also navigate to the toolbar with F6 (Regina)
+ possibly that works
Guides
+ Online version for Draw Guide 7.6 (ohallot)
+ updtes in Calc (S. Fanning)
+ Updates in Draw & Impress guides (P. Schofield)
+ Bugzilla Documentation statistics
279(279) bugs open
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
created 18(10) 31(9) 52(8) 228(-14)
commented 35(29) 73(22) 186(29) 901(-3)
resolved 8(8) 13(8) 22(8) 113(-3)
+ top 10 contributors:
Vernon, Stuart Foote made 44 changes in 1 month, and 63 changes in 1 year
Olivier Hallot made 36 changes in 1 month, and 299 changes in 1 year
Alain Romedenne made 10 changes in 1 month, and 13 changes in 1 year
Kaganski, Mike made 9 changes in 1 month, and 61 changes in 1 year
Dan Dascalescu made 7 changes in 1 month, and 7 changes in 1 year
Heiko Tietze made 6 changes in 1 month, and 89 changes in 1 year
Stéphane Guillou made 6 changes in 1 month, and 276 changes in 1 year
Dione Maddern made 5 changes in 1 month, and 5 changes in 1 year
*UNKNOWN* made 5 changes in 1 month, and 6 changes in 1 year
Juan José González made 4 changes in 1 month, and 4 changes in 1 year
* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
249(249) (topicUI) bugs open, 34(34) (needsUXEval) needs to be evaluated by the UXteam
+ Updates:
BZ changes 1 week 1 month 3 months 12 months
added 3(-2) 8(3) 10(3) 23(3)
commented 60(-30) 235(21) 531(1) 2077(0)
removed 0(0) 0(0) 2(0) 15(1)
resolved 8(0) 36(-1) 87(5) 319(0)
+ top 10 contributors:
Heiko Tietze made 132 changes in 1 month, and 1265 changes in 1 year
Vernon, Stuart Foote made 56 changes in 1 month, and 284 changes in 1 year
Ady made 43 changes in 1 month, and 148 changes in 1 year
Stéphane Guillou made 30 changes in 1 month, and 602 changes in 1 year
Rafael Lima made 21 changes in 1 month, and 83 changes in 1 year
Ilmari Lauhakangas made 18 changes in 1 month, and 192 changes in 1 year
Bob Harvey made 13 changes in 1 month, and 13 changes in 1 year
Timur made 11 changes in 1 month, and 30 changes in 1 year
Kaganski, Mike made 10 changes in 1 month, and 97 changes in 1 year
Eyal Rozenberg made 8 changes in 1 month, and 172 changes in 1 year
+ Offer to download & install missing fonts from online sources
+ https://bugs.documentfoundation.org/show_bug.cgi?id=159950
+ good to avoid auto-installing fonts from remote sources (Heiko)
+ FILEOPEN When I say "lowriter foo.txt" and foo.txt does not exist,
it should open a new empty document that saves to that name instead of dying
+ DUP of https://bugs.documentfoundation.org/show_bug.cgi?id=40227
+ makes sense for e.g. vim, but probably not for us (Heiko)
+ Table cells merge: some cells disappear
+ https://bugs.documentfoundation.org/show_bug.cgi?id=159629
+ no cell height, height is taken from row properties (Heiko)
+ would be nice to keep it simple
+ technically it's probably not a bug (Regina)
+ good to solve it by setting the default to a better value (row height)
+ input in the bug is welcome
* Crash Testing (Caolan)
+ 2(-6) import failure, 0(-5) export failures
- just 2 now
- https://wiki.documentfoundation.org/Development/Crashtesting
+ 3 (+2) coverity issues
- fixes the new two submitted
+ 6 ossfuzz issues
- 1 crash (openssl instead of nss configuration)
* Crash Reporting (Xisco)
+ 7.6.3.2 8219(+316)
+ 7.6.4.1 34187(+3182)
+ 7.6.5.2 212(+0)
+ 24.2.0.3 7530(+2385)
+ 7.6.5.2
- void rtl::str::release<_rtl_uString>(_rtl_uString*)
- Fixed after 7b46c77366fb3effd2de9bf5ba11ebd3c064974a
- static bool cppu::idefaultConstructElements(struct _sal_Sequence * *, struct _typelib_TypeDescriptionReference *, long, long, long)
- Not fixed after 6a0d4247b73d16d7e70ab146aadfbed75721f8bd
- Fixed in 24.2. Armin's work. Hard to backport
* Mentoring (Hossein)
+ Reviewed submissions from the newcomers
+ Finalized and published a blog post on an EasyHack
+ Writer tables converted to plain text – difficultyInteresting EasyHack
https://dev.blog.documentfoundation.org/2024/02/29/writer-tables-converted-to-plain-text-difficultyinteresting-easyhack/
committer... 1 week 1 month 3 months 12 months
open 76(6) 161(22) 165(26) 165(26)
reviews 464(42) 1486(-28) 3630(116) 12032(44)
merged 333(38) 1219(51) 3344(102) 12493(6)
abandoned 17(7) 54(9) 190(2) 654(4)
own commits 219(52) 743(35) 2307(44) 9526(-33)
review commits 81(-17) 303(14) 891(31) 3071(-19)
contributor... 1 week 1 month 3 months 12 months
open 53(34) 116(-131) 117(-130) 118(-130)
reviews 940(142) 3070(190) 7976(256) 30240(54)
merged 31(-7) 108(6) 358(10) 1991(-32)
abandoned 149(138) 182(137) 266(134) 669(134)
own commits 37(-12) 144(6) 359(27) 1048(-10)
review commits 0(0) 0(0) 0(0) 0(0)
+ easyHack statistics:
needsDevEval 8(8) needsUXEval 1(1) cleanup_comments 323(323)
total 410(410) assigned 25(25) open 352(352)
+ top 10 contributors:
Kurt Nordback made 20 patches in 1 month, and 21 patches in 1 year
Dione Maddern made 12 patches in 1 month, and 22 patches in 1 year
Armin Le Grand (allotropia) made 11 patches in 1 month, and 86 patches in 1 year
Luv Sharma made 7 patches in 1 month, and 14 patches in 1 year
Weblate made 4 patches in 1 month, and 20 patches in 1 year
Stéphane Guillou made 4 patches in 1 month, and 56 patches in 1 year
Hubert Figuière made 4 patches in 1 month, and 4 patches in 1 year
vivek javiya made 3 patches in 1 month, and 5 patches in 1 year
Devansh Varshney made 3 patches in 1 month, and 3 patches in 1 year
Akshay Warrier made 3 patches in 1 month, and 6 patches in 1 year
+ top 10 reviewers:
Caolán McNamara made 184 review comments in 1 month, and 1196 in 1 year
Vajna, Miklos made 168 review comments in 1 month, and 1032 in 1 year
Grandin, Noel made 98 review comments in 1 month, and 628 in 1 year
Michael Stahl made 90 review comments in 1 month, and 1020 in 1 year
Christian Lohmaier made 78 review comments in 1 month, and 372 in 1 year
Thorsten Behrens made 78 review comments in 1 month, and 620 in 1 year
Taichi Haradaguchi made 68 review comments in 1 month, and 142 in 1 year
Ilmari Lauhakangas made 66 review comments in 1 month, and 472 in 1 year
Xisco Fauli made 60 review comments in 1 month, and 782 in 1 year
Nabet, Julien made 56 review comments in 1 month, and 956 in 1 year
+ Patches automatically abandoned:
vcl: move GetCaretPositions() from OutputDevice to Edit ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158081
vcl: extract LocalizeString() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158312
vcl: set the bidi flags outside of ImplPrepareLayoutArgs() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158313
vcl: extract lcl_GetLayoutFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158314
vcl: OutputDevice::ImplPrepareLayoutArgs() no longer needed ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158315
tdf#74702 vcl: introduce OutputDevice::GetTextLayout() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158316
vcl: ImplLayout() uses physical nPixelWidth ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158335
vcl: extract lcl_GenerateDXPixelArray() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158336
vcl: extract lcl_SkipNewline() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158466
vcl: move the max text line width into ImplMultiTextLineInfo ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158467
vcl: extract lcl_ShouldHyphenate() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158468
vcl: extract lcl_GetHyphenatedWordBreakPos() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158469
vcl: extract TextLayoutCommon::BreakFinalWord() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158470
vcl: TextLayoutCommon::GetTextLines() should get width from the bounding rect ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158577
vcl: move OutputDevice text layout functions to textlayout.cxx ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158581
vcl: split out text layout functions into seperate header and source files ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158603
vcl: extract local functions from GetCharWidths() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158605
vcl: move variables closer to first usage in LayoutText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158638
vcl: extract GenericSalTextLayout::FindScriptSubRuns() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158639
vcl: extract GenericSalTextLayout::GenerateSubRuns() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158640
vcl: flatten GenericSalTextLayout::GenerateSubRuns() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158641
vcl: extract GenericSalTextLayout::IsDirectionTopToBottom() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158642
vcl: extract lcl_GetRunIndex() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158644
vcl: extract tuple returning lcl_GetGlyphInfo() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158645
vcl: extract advance, x offset and y offset functions for GenericSalTextLayout ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158655
vcl: extract local function lcl_GetGlyphItemFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158658
vcl: extract GenericSalTextLayout::PopulateGlyphItems() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158660
vcl: SalLayoutGlyphsImpl -> GlyphItems ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158683
vcl: migrate SetNeedFallback() to AddMissingGraphemeToFallbackRun() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158684
vcl: move disable kerning and ligatures into ParseFeatures() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158712
vcl: introduce vcl::font::Features ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158792
vcl: migrate more into lcl_InitHbBuffer() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158795
vcl: extract lcl_GetBaseOffset() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158801
vcl: split PopulateGlyphItems() for loop ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158806
vcl: let LogicalFontInstance get the HarfBuzz vertical glyphs ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158850
vcl: make GenericSalTextLayout::HasVerticalAlternate() a local function ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158877
vcl: make GenericSalTextLayout::IsDirectionTopToBottom() a local function ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158878
vcl: make GenerateSubRuns() a local function ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158916
vcl: setup consts for FindScriptSubRuns() and rename lcl_GenerateSubRuns() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158917
vcl: make LogicalFontInstance::IsGraphiteFont() const ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158920
vcl: make FindScriptRuns() take a LogicalFontInstance parameter ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158921
vcl: move functions to LogicalFontInstance from GenericSalTextLayout ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158926
vcl: move GlyphItems to own files and add to vcl::font namespace ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158928
vcl: move impglyphitem.hxx to font/GlyphItem.hxx ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158929
vcl: move GlyphItem into vcl::font namespace ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158930
vcl: move aCurrPos closer to first usage ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158932
vcl: rename variables in lcl_GetGlyphInfo() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158934
vcl: add unit test for layout of empty string in GenericSalTextLayout ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158935
vcl: pGlyphs is never used in Edit::GetCaretPositions() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158943
vcl: rename SalLayoutGlyphs to vcl::font::SalTextLayoutGlyphs ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158944
vcl: move glyphitemcache.hxx -> SalTextLayoutGlyphsCache.hxx ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158947
vcl: move SalTextLayoutGlyphsCache into vcl::font namespace ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158948
vcl: rename IsControlChar() to lcl_IsControlChar() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158960
vcl: mpFontInstance is guaranteed to be instantiated at this point ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158961
vcl: have SalLayoutText::LayoutText() take a SalTextLayoutGlyphs ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158962
vcl: introduce SalTextLayoutGlyphs::GetFontFace() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158963
vcl: extract GenericSalTextLayout::ProcessGlyphs() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158980
vcl: extract debug function SalTextLayoutGlyphs::CheckGlyphIntegrity() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158982
vcl: extract local adjustment functions from ApplyDXArray() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158994
vcl: move language detection out of loop ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/158996
vcl: remove extraneous call to lcl_GetLayoutFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159023
vcl: mpFontInstance is at this point guaranteed to be instantiated ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159024
vcl: introduce LogicalFontInstance::RecodeString() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159025
vcl: extract lcl_InvalidStringLength() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159026
vcl: collapse calling of lcl_GetLayoutFlags() into one statement ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159027
vcl: test whether OutputDevice::GetTextLayout() detects invalid string length ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159061
vcl: introduce Font::IsAsianKerning() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159088
vcl: remove extraneous braces ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159089
vcl: remove dependency of lcl_GenerateDXPixelArray() on OutputDevice ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159256
vcl: migrate lcl_GenerateDXPixelArray() to KernArraySpan ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159257
vcl: make GetBiDiLayoutFlags() a standalone function ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159259
tdf#156333 Added tests for reading and writing <tint> value ( Vladislav Tarakanov )
- https://gerrit.libreoffice.org/#/c/159293
vcl: rename the confusing variable mbInitFont in OutputDevice ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159327
vcl: explain OuptutDevice's mxFontCache ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159329
vcl: bail early in GetGlyphFallbackFont() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159330
vcl: reformat GetLocalizedChar() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159387
vcl: rearrange Library_vcl.mk ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159474
vcl: extract LayoutText() from ImplLayout() in OutputDevice ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159475
vcl: remove unneeded pLayoutCache parameter from OutputDevice::GetTextWidth() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159476
vcl: introduce GetTextWidthFromGlyphs() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159477
vcl: split out GetTextArrayFromGlyphsAndLayout() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159478
vcl: SalTextLayout FillDXArray() and GetTextWidth() do different things ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159479
vcl: allow usage of ImplPixelToLogic() in other vcl source files ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159480
vcl: extract functionality into SalTextLayout::PopulateKernArray() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159481
vcl: format SalTextLayout source files ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159482
vcl: no longer use GetTextArray() in GetTextWidth() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159483
vcl: only GetTextWidth() now returns the width of text ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159556
vcl: collapse if statements in OutputDevice::DrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159558
vcl: extract lcl_GetClippedDisplayTextBox() from OutputDevice::DrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159559
vcl: extract lcl_GetRectDimensions() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159560
vcl: extract lcl_GetTargetDeviceTextColors() from OutputDevice::ImplDrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159595
vcl: nHeight can be const ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159596
vcl: move aPos closer to first use ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159597
vcl: make nWidth and nHeight const and move closer to first use ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159598
vcl: extract lcl_DrawMultiLineText() from OutputDevice::ImplDrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159599
vcl: extract lcl_DrawText() from OutputDevice::ImplDrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159600
vcl: extract lcl_GetLastLine() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159601
vcl: extract lcl_DrawMnemonicLine() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159602
vcl: extract lcl_GetMultiLineDrawTextFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159603
vcl: extract lcl_GetLineCapacityOfRect() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159604
vcl: extract lcl_DrawTextLine() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159606
vcl: clarify nLines to nRectLinesCapacity ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159608
vcl: extract lcl_GetMultiLineTextAlignment() and helpers ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159609
vcl: collapse if statement in OutputDevice::ImplDrawTextDirect() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159615
vcl: use lcl_GetHorizontalTextAlignment() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159616
vcl: extract lcl_GetSingleLineTextAlignment() and helpers ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159617
vcl: extract lcl_GetMnemonicDimensions() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159618
vcl: remove nWidth and nHeight from lcl_DrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159619
vcl: extract lcl_GetDrawTextFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159620
vcl: extract lcl_ShouldDrawMnemonics() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159621
vcl: add curly braces to make OutputDevice::GetTextRect() easier to read ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159622
vcl: split nLine assignment into it's own block ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159623
vcl: extract lcl_GetTextRectLineCapacity() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159624
vcl: split loop to assign nMaxWidth and pInfo->mnMaxWidth ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159629
vcl: make the loop intent more clear ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159630
vcl: extract functions from ImplDrawTextSpecial() and move into ImplDrawText() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159644
vcl: flatten lcl_GetDrawTextFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159645
vcl: flatten lcl_GetDrawTextFlags() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159651
vcl: make OutputDevice::DrawTextArray() readable ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159652
vcl: make OutputDevice::DrawStretchText() readable ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159653
vcl: can only draw a mnemonic line if the position is less than the string len ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159654
vcl: extract lcl_SetTextRectInfoMaxWidth() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159655
vcl: introduce OutputDevice::ImplDrawRotatedRect() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159657
vcl: flatten OutputDevice::ImplGetTextBoundRect() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159658
vcl: introduce OutputDevice::GetFontHeight() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159659
vcl: test TextLayoutCommon::TestBreaksSimple() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159674
vcl: remove unnecessary xBI parameter in TextLayoutCommon functions ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159920
vcl: (minor) change parameter name ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159921
vcl: change parameter in TextLayoutCommon::BreakLine() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159922
vcl: allow the locale to be set in TextLayoutCommon ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159925
vcl: TextLayoutCommon::BreakLine() doesn't need the DrawTextFlags parameter ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159942
vcl: initialize text hyphenator in TextLayoutCommon's constructor ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159943
vcl: remove unnecessary rLocale param from TextLayoutCommon::BreakFinalWord() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159944
vcl: make TextLayoutCommon::GetTextLines() return ImplMultiTextLineInfo ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159966
vcl: test TextLayoutCommon::GetTextLines() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159968
vcl: move ITextLayout into vcl::text namespace ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159970
vcl: TextLayoutCache.hxx moved to vcl/inc/text ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159972
vcl: move ControlTextRenderer.[ch]xx into vcl/source/control/ ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159973
vcl: move TextLayoutCache.hxx to vcl/inc/text ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/159977
vcl: make getFallbackLayout() a local function ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160531
connectivity : simplify SharedRessources, no lock anymore. ( Arnaud Versini )
- https://gerrit.libreoffice.org/#/c/160541
vcl: extract ImplLayoutArgs::GetCodeUnits() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160672
vcl: extract lcl_IsForcedFallbackFont() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160673
vcl: compile font files first ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160687
vcl: rename pFallbackData to pFallbackFontFamily in GetGlyphFallbackFont() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160688
vcl: extract lcl_GetGlyphFallbackFontData() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160689
vcl: flatten lcl_GetMissingCode() ( Chris Sherlock )
- https://gerrit.libreoffice.org/#/c/160710
+ big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
Ahmed Hamed
Anish Deshpande
Po-Yen Huang (OSSII)
Zeph Chai
* Outreachy (Ilmari)
+ find in the sidebar for Writer: project time extended (5 weeks)
+ qt welding project: official project completed
* GSoC (Ilmari)
+ https://summerofcode.withgoogle.com/programs/2024/organizations/libreoffice
+ https://wiki.documentfoundation.org/Development/GSoC/2024
+ till March 18: Potential participants discuss application ideas
+ Code review: who wants to help with beginner patches?
+ maybe find who worked on that area in the recent past and add those people as reviewers? (Miklos)
+ happy to help out (Michael W)
* Commit Access
* Developer Certification (Stephan/Miklos/László/Gabriel)
+ resting since: 19 weeks (limit: 20 weeks)
* Jenkins / CI update (Cloph)
gerrit_android_aarch64 jobs: 219 ok: 204 ko: 13 fail ratio: 5.94% mean_ok: 8 ( 16) median_ok: 6 ( 11)
gerrit_android_arm jobs: 221 ok: 209 ko: 9 fail ratio: 4.07% mean_ok: 8 ( 16) median_ok: 6 ( 11)
gerrit_android_x86 jobs: 218 ok: 204 ko: 12 fail ratio: 5.50% mean_ok: 8 ( 16) median_ok: 6 ( 12)
gerrit_android_x86_64 jobs: 222 ok: 206 ko: 12 fail ratio: 5.41% mean_ok: 8 ( 16) median_ok: 6 ( 12)
gerrit_linux_clang_dbgutil jobs: 448 ok: 357 ko: 78 fail ratio: 17.41% mean_ok: 35 ( 43) median_ok: 32 ( 41)
gerrit_linux_gcc_release jobs: 546 ok: 418 ko: 102 fail ratio: 18.68% mean_ok: 17 ( 22) median_ok: 14 ( 16)
gerrit_mac jobs: 442 ok: 391 ko: 30 fail ratio: 6.79% mean_ok: 49 ( 51) median_ok: 48 ( 48)
gerrit_windows jobs: 453 ok: 339 ko: 93 fail ratio: 20.53% mean_ok: 59 (102) median_ok: 48 ( 76)
gerrit_master_ml jobs: 565 ok: 284 ko: 229 fail ratio: 40.53% mean_ok: 121 (122) median_ok: 94 ( 94)
gerrit_master jobs: 61 ok: 30 ko: 25 fail ratio: 40.98% mean_ok: 86 ( 93) median_ok: 71 ( 71)
gerrit_master_seq jobs: 511 ok: 258 ko: 206 fail ratio: 40.31% mean_ok: 122 (126) median_ok: 98 ( 98)
+ https://dev-www.libreoffice.org/tmp/gerrit_240229.html
+ tests that failed more than twice in last seven days
3 CppunitTest_sw_layoutwriter2 gerrit_windows
4 aborted by jenkins job timeout gerrit_windows
4 CppunitTest_sw_ooxmlexport12 gerrit_windows
5 JunitTest_chart2_unoapi gerrit_linux_clang_dbgutil
6 JunitTest_sw_complex gerrit_linux_clang_dbgutil
8 UITest_writer_tests8 gerrit_linux_clang_dbgutil
15 CppunitTest_sw_a11y gerrit_linux_gcc_release
17 CppunitTest_sw_a11y gerrit_windows
22 CppunitTest_toolkit_a11y gerrit_linux_gcc_release
+ this week was OK in terms of bot failures (Cloph)
+ last week the ML job put ~all changes to the risky category
+ the queue was larger than usual, mostly the PDF import patches
+ hope this settled down now
+ seeing lots of a11y test failures? (Michael W)
+ think the CppunitTest_toolkit_a11y failures are related to a pending change of Noel (Xisco)
- https://gerrit.libreoffice.org/c/core/+/163680
- CI just did its job here, good (Miklos, Cloph)
* What’s cooking (Miklos)
+ A11y update (Michael W)
* gtk4: new GtkAtspiSocket API in Gtk 4.14, could potentially be used to
do own AT-SPI implementation + bridge that to the Gtk widget hierarchy,
discussion at https://gitlab.gnome.org/GNOME/gtk/-/issues/6197#note_2025466
* qt6: API for reporting a11y object attributes (QAccessibleAttributesInterface)
merged upstream + implemented in LO
* new keyboard shortcut for jumping to foot-/endnote, thanks Heiko! (tdf#159863)
* improvements to Writer Navigator a11y (tdf#159910)
* some crash fixes
+ still working on importing 3D scenes from MSO (Regina)
+ currently thinking about lighting
+ current ODF is not able to describe these lights from MSO
+ see discussion on the libreoffice@ list, also has input from Armin
+ pdf import improvements (David)
+ cmake find modules for SDK examples (Hossein)
+ Set of patches from Konstantin (WIP)
https://gerrit.libreoffice.org/c/core/+/162978
+ Similar structure is needed for qmake
+ would this mean duplicated build systems for each example? (Miklos)
+ for each example, the maintenance would be low, hopefully (Hossein)
+ would be the goal to have old/cmake/qmake, 3 parallel build systems? (Miklos)
+ yes, for now (Hossein)
+ the cmake part for each example is small
+ smells like explosion of combinatorics (Stephan)
+ would be careful before going down that road
+ if the end goal is to settle down on cmake, love it (Thorsten)
+ but 3 in the long run is far from ideal.
+ cmake is not that exotic, we require it already for doxygen (Miklos)
+ which makes it supported on CI already (Thorsten)
+ if interested in doing the work + update the docs, then why not, as long as it's a single build system (Stephan)
+ but then do avoid qmake, and do switch over from gmake at the end
+ avoids the exploson
+ Excel 2021 functions (Balazs Varga)
+ XLOOKUP, XMATCH, FILTER etc
+ also ironically some functions came from google sheets originally,
then -> excel -> Calc
+ Help pages ready to be filled (ohallot).
+ we also try to submit suitable ODF TC enhancement requests (Thorsten)
+ parallel computation has some special-cases for LOOKUP (Caolan)
+ keep that in mind for XLOOKUP
* COOL Days 2024 (Miklos)
+ https://www.collaboraoffice.com/cool-days-2024/ 8th -> 10th April
+ contributors can submit 5 mins talk proposals at https://eventyay.com/e/0512424d/cfs
+ LibreOffice Technology hackfest as part of it
* QA update (Xisco)
+ UNCONFIRMED: 1132 (+12)
+ enhancements: 272 (+7)
+ needsUXEval: 5 (+3)
+ haveBackTrace: 9 (+0)
+ needsDevAdvice: 44 (-1)
+ documentation: 7 (-3)
+ android: 0 (+0)
+ iOS: 0 (+0)
+ Online: 9 (+0)
+ Most pressing bugs:
New:
None
Old:
+ Crash at undo of RTF Paste
+ https://bugs.documentfoundation.org/show_bug.cgi?id=159385
+ bisected to Tomaz
Fixed:
+ LibreOffice 7.6 stalls/crashes under Windows 11 with Norwegian locale when opening file dialog
+ https://bugs.documentfoundation.org/show_bug.cgi?id=157135
+ 74 comments :) (Miklos)
+ Fixed. Thanks to Mike Kaganski
+ New high severity bugs of the week:
+ Function COUNTIFS empty cells are counted up to the nearest filled one, EDITING
+ https://bugs.documentfoundation.org/show_bug.cgi?id=159544
+ bisected to Lubos
* QA stats (Stéphane)
+ Interesting consolidated reports:
* Mouse-hold preview differs from result when changing a connector via dragging: https://bugs.documentfoundation.org/show_bug.cgi?id=130937
* Animation triggered by object click resets at the end: https://bugs.documentfoundation.org/show_bug.cgi?id=133002
+ Dashboard data updated: https://stragu.shinyapps.io/lo_qa_dashboard/
+ https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
+123 -26 (-108) overall)
many thanks to the top bug squashers:
QA Administrators 13
Buovjaga 9
Stéphane Guillou (stragu) 8
Olivier Hallot 7
Heiko Tietze 5
Mike Kaganski 5
Gabor Kelemen (allotropia) 4
Julien Nabet 4
Justin L 4
Michael Stahl (allotropia) 4
+ top 10 bugs reporters:
Gabor Kelemen (allotropia) 10
Rafael Lima 6
Regina Henschel 5
lvm 4
Olivier Hallot 3
Stéphane Guillou (stragu) 3
Alvaro Segura 2
Justin L 2
Kuba Orlik 2
Mike Kaganski 2
+ top 10 bugs fixers:
Olivier Hallot 6
Justin Luth 4
Nabet, Julien 4
Kaganski, Mike 3
Xisco Fauli 3
Attila Szűcs 2
Jim Raykowski 2
Kelemen, Gabor 2
Michael Stahl 2
Patrick Luby 2
+ top 10 bugs confirmers:
Stéphane Guillou 21
Nabet, Julien 9
Vernon, Stuart Foote 6
Xisco Fauli 6
Ady 5
Heiko Tietze 5
Ilmari Lauhakangas 5
*UNKNOWN* 3
Bielefeld, Rainer 3
Kaganski, Mike 3
* Bisected bugs open: keyword 'bisected'
+ more accurate - down to a single commit.
+ http://bit.ly/2dyIfDy
+
done by:
Kevin Suo 5
Raal 4
Stéphane Guillou 3
Xisco Fauli 2
Aron Budea 1
Ilmari Lauhakangas 1
Kelemen, Gabor 1
Michael Stahl 1
* Bibisected bugs open: keyword 'bibisected'
+ http://bit.ly/2cSCXlS
+
done by:
Raal 4
Michael Warner 3
Stéphane Guillou 3
Aron Budea 2
Ilmari Lauhakangas 2
Xisco Fauli 2
Kelemen, Gabor 1
* all bugs tagged with 'regression'
+ 1255(-3) bugs open of 13216(+16) total 22(+0) high prio.
done by:
Stéphane Guillou 5
Raal 3
Ilmari Lauhakangas 2
Ady 1
Kelemen, Gabor 1
Michael Warner 1
Michael Stahl 1
OfficeUser 1
Xisco Fauli 1
* ~Component count net * high severity regressions
+ http://bit.ly/1HWHb3E
Writer - 14(-1)
LibreOffice - 2(+0)
Calc - 1(+0)
Draw - 1(+1)
Impress - 1(+0)
Printing and PDF export - 1(+0)
UI - 1(+0)
by OS:
All - 15(-1)
Linux - 6(+1)
Mac OS X - 0(+0)
Windows - 1(+0)
* ~Component count net * all regressions
+ http://bit.ly/1BUdI8i
Writer: other - 452(-3)
Calc - 231(+1)
Impress - 125(-3)
LibreOffice - 54(-2)
Crashes - 51(-1)
Draw - 51(+1)
Writer: docx filter - 45(+0)
Base - 38(+0)
Borders - 36(+1)
UI - 35(+0)
Writer: perf - 34(+0)
Writer: other filter - 31(+0)
Printing and PDF export - 26(+0)
Chart - 23(+0)
RTL - 23(+0)
filters and storage - 23(+0)
BASIC - 19(+0)
Writer: doc filter - 16(+0)
graphics stack - 12(+1)
Formula Editor - 7(+0)
framework - 3(+0)
Extensions - 2(+0)
sdk - 2(+0)
Linguistic - 1(+0)
More information about the Libreoffice-qa
mailing list