[Libreoffice-ux-advise] [PUSHED] Fix for fdo39748 Easy hack: Cleanup extensions list
michael.meeks at suse.com
Mon Nov 28 12:18:51 PST 2011
On Mon, 2011-11-28 at 11:19 -0200, Olivier Hallot wrote:
> Please find attached a patch for FDO 39748, Easy Hack Cleanup
> Extension list.
Lovely ! :-) really glad you got to this before the feature freeze,
nice to see it closed.
> Some post-commit I missed (I don't know how to fix a patch):
> in /desktop/source/deployment/gui/dp_gui.hrc, please drop the line
> +#define RID_EM_BTN_SELECT 23
> in /desktop/source/deployment/gui/dp_gui_dialog2.cxx, please drop the line
> + aPos = Point( 0, 5 );
Any chance you could knock up a new patch to do that ? also it might be
+IMPL_LINK( ExtMgrDialog, HandleExtTypeCbx, void*, EMPTYARG )
returns 0 instead of 1 - it seems the value is ignored anyway, and 0
might be more ignoreable when read ? :-)
Of course, the UX guys may have some advice :-) I wonder if (perhaps)
there is just a little bit too much grey space between the bottom of the
list box, and the "Types of extensions" widget (?) They might also have
some advice on the defaults - should we show built-in extension by
default (eg.) ?
Anyhow - it looks great; no doubt we should add this to:
With suitable credits etc. & close the bug.
Thanks again !
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 136601 bytes
Desc: not available
More information about the Libreoffice-ux-advise