[Libreoffice] Inconsistencies in GoDownSel and GoUpSel (cell selection in Calc)

[Olivier Hallot]

Hi

Investigating sc/sdi/cellsh.sdi

I see the following code for the commands GoDown, GoDownSel, GoUp, GoUpSel
(+ left and right movement and selection)

//cursor down
SfxVoidItem GoDown SID_CURSORDOWN
    (
        SfxInt16Item By FN_PARAM_1,
        SfxBoolItem      Sel FN_PARAM_2
    )
    [
        ExecMethod = ExecuteCursor ;
        StateMethod = GetStateCursor ;
        Cachable ;
    ]

    SfxVoidItem GoDownSel SID_CURSORDOWN_SEL
    (
        SfxInt16Item By FN_PARAM_1
    )
    [
        Export = FALSE ;
        ExecMethod = ExecuteCursorSel ;
        StateMethod = GetStateCursor ;
        Cachable ;
    ]

// cursor up

    SfxVoidItem GoUp SID_CURSORUP
    (
        SfxInt16Item By FN_PARAM_1,
        SfxBoolItem      Sel FN_PARAM_2
    )
    [
        ExecMethod = ExecuteCursor ;
        StateMethod = GetStateCursor ;
        Cachable ;
    ]
    SID_CURSORUP_SEL    [ ExecMethod = ExecuteCursorSel; StateMethod =
GetStateCursor; ]

So it looks like GoDownSel has an argument "By", which seems to be "select
FN_PARAM_1 cells down", but GoUpSel (GoRightSel and GoLeftSel) does not have
this parameter.

Which one is the correct?

Thanks
-- 
Olivier Hallot
Founder and Steering Commitee Member
The Document Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110727/78ef2d1c/attachment.htm>