[Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

Michael Meeks michael.meeks at novell.com
Mon Mar 21 10:10:46 PDT 2011

On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote:
> I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it 
> was never defined. It builds successfully. Could someone please review 
> to make sure that nothing was deleted accidentally?

@@ -427,7 +425,7 @@ void OslStream::SetSize( sal_uIntPtr nSize )
     maFile.setSize( (sal_uInt64)nSize );
	I would fully remove that :-)

-        if( !hasUno() )

	and hasUno has no side-effects ? ie. changes no global / local / object
state, and calls nothing that does that ?

	Otherwise it looks perfect to me, go go go ! :-)

	And a nice cleanup too,



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list