[Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

Christina Roßmanith ChrRossmanith at web.de
Mon Mar 21 11:27:47 PDT 2011


Am 21.03.2011 18:10, schrieb Michael Meeks:
> On Mon, 2011-03-21 at 13:44 +0100, Christina Roßmanith wrote:
>> I've removed all blocks of code #ifdef'ed by _OLD_FILE_IMPL because it
>> was never defined. It builds successfully. Could someone please review
>> to make sure that nothing was deleted accidentally?
> @@ -427,7 +425,7 @@ void OslStream::SetSize( sal_uIntPtr nSize )
>       maFile.setSize( (sal_uInt64)nSize );
>   }
>
> -#endif
> +//#endif
Of course!
>
> 	I would fully remove that :-)
>
> -        if( !hasUno() )
>
> 	and hasUno has no side-effects ? ie. changes no global / local / object
> state, and calls nothing that does that ?
Oops, indeed I didn't pay attention that it's not just a variable. I'll 
check that. That's why I've asked for more eyes  :-)

Christina


More information about the LibreOffice mailing list